cf: implement manifest.yml #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For certain tests, the app may not field a full http server but simply a trivial tcp server or a looping process. In such cases, CF needs to switch away from the default healthcheck mode of "port". If switchblade supports manifest, this can be provided via a manifest (also all other options supported by the manifest). See test pre-switchblade-conversion that requires this change: https://github.com/cloudfoundry/ruby-buildpack/blob/v1.10.17/src/ruby/integration/deploy_an_app_with_no_gemfile_test.go#L45 There is no equivalent on the docker platform.
sophiewigmore
approved these changes
Sep 9, 2024
arjun024
added a commit
to cloudfoundry/ruby-buildpack
that referenced
this pull request
Sep 9, 2024
arjun024
added a commit
to cloudfoundry/ruby-buildpack
that referenced
this pull request
Sep 9, 2024
arjun024
added a commit
to cloudfoundry/ruby-buildpack
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain tests, the app may not field a full http server but simply a trivial tcp server or a looping process. In such cases, CF needs to switch away from the default healthcheck mode of "port". If switchblade supports manifest, this can be provided via a manifest (also all other options supported by the manifest).
See test pre-switchblade-conversion that requires this change: https://github.com/cloudfoundry/ruby-buildpack/blob/v1.10.17/src/ruby/integration/deploy_an_app_with_no_gemfile_test.go#L45
There is no equivalent on the docker platform.